This is the mail archive of the
mailing list for the Cygwin project.
Re: [setup PATCH] Another micropatch heading towards next_dialogremoval (1)
Robert Collins wrote:
> On Sat, 2003-07-26 at 20:14, Max Bowsher wrote:
>> Index: ChangeLog
>> RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/ChangeLog,v
>> retrieving revision 2.373
>> diff -u -p -r2.373 ChangeLog
>> --- ChangeLog 26 Jul 2003 09:01:35 -0000 2.373
>> +++ ChangeLog 26 Jul 2003 10:06:57 -0000
>> @@ -0,0 +1,6 @@
>> +2003-07-26 Max Bowsher <email@example.com>
>> + * dialog.h: (NEXT): Remove obsolete macro.
>> + * site.cc (save_dialog): Remove use of NEXT(). Replace with an exit,
>> + as this is a serious but incredibly unlikely runtime error.
> So, today we handle the situation, after this we don't?
Today, we don't handle the situation because NEXT() is obsolete code that
fails to actually do anything.
After this, we kind of handle the situation, and will be able to handle the
situation properly one we have full use of exceptions.
> It seems better to me to loop (say max 2 times) if such a race occurs,
> rather than reentering the dialog or exiting.
Try to actually trigger it. The dialog changes so fast, it is impossible to
So, if a user can't trigger this oddness, the only remaining cause is
Windows oddness, which is good reason to bail out.
Actually, my preferred change would be to not try to detect this error,
since I don't think it can occur.