This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] Another micropatch heading towards next_dialogremoval (1)


Robert Collins wrote:
> On Mon, 2003-07-28 at 04:20, Max Bowsher wrote:
>> We seem to have consensus that this error condition cannot occur,
therefore
>> no complex retry loop is required.
>>
>> OK to commit now?
>
> Not as it was. Just remove the check and make the dang thing tidy...

Like so?

Index: dialog.h
===================================================================
RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/dialog.h,v
retrieving revision 2.9
diff -u -p -r2.9 dialog.h
--- dialog.h 23 Jul 2003 22:28:30 -0000 2.9
+++ dialog.h 27 Jul 2003 21:33:46 -0000
@@ -40,9 +40,6 @@ D (do_postinstall);

 #undef D

-/* end this dialog and select the next.  Pass 0 to exit the program */
-#define NEXT(id) EndDialog((HWND)h, 0), next_dialog = id
-
 /* Get the value of an EditText control.  Pass the previously stored
    value and it will free the memory if needed. */

Index: site.cc
===================================================================
RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/site.cc,v
retrieving revision 2.29
diff -u -p -r2.29 site.cc
--- site.cc 27 Jul 2003 10:29:53 -0000 2.29
+++ site.cc 27 Jul 2003 21:36:53 -0000
@@ -163,12 +163,7 @@ save_dialog (HWND h)
   if (sel_count > 0)
     {
       int sel_buffer[sel_count];
-      int sel_count2 = SendMessage (listbox, LB_GETSELITEMS, sel_count,
-        (LPARAM) sel_buffer);
-      if (sel_count != sel_count2)
- {
-   NEXT (IDD_SITE);
- }
+      SendMessage (listbox, LB_GETSELITEMS, sel_count, (LPARAM)
sel_buffer);
       for (int n = 0; n < sel_count; n++)
  {
    int mirror =


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]