This is the mail archive of the
mailing list for the Cygwin project.
Re: [setup PATCH] next_dialog micropatch (2)
Robert Collins wrote:
> On Mon, 2003-07-28 at 20:07, Max Bowsher wrote:
>> I don't think that the fact that a big cleanup is possible should prevent
>> small cleanup from being done.
> I agree. But as the larger will involve reversing this specific small
> cleanup. Secondly creating a couple of classes with a static member each
> is only slightly more effort, and won't involve reversing any changes
> when the 'big' cleanup is done.
If we do add a class, it should probably be a thread class from which all of
our threaded tasks can derive. Regardless, I don't see that any further
cleanup will reverse these changes. I can see how it may involve changing
the same lines to a third form, but that is not a reversal.
In any case, this is a tiny patch, and even *if* (partial) reversal is
required, to do so will be trivial. We can benefit *now* from this cleanup,
whereas classes may be months in the future.
Requesting to commit,