This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Er I mean... (was: RE: [PATCH] next_dialog micropatch (3)(was: RE: [setup PATCH] next_dialog micropatch (2)))


Robert Collins wrote:
> On Tue, 2003-07-29 at 13:47, Gary R. Van Sickle wrote:
>> ...this straightforward patch:
>> 
>> 2003-07-28  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
>> * dialog.h (do_fromcwd): Change function declaration.
>> * fromcwd.cc (do_fromcwd): Change return type to bool.  Eliminate
>> use of next_dialog, return true or false instead.
>> * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
>> value instead of next_dialog.
> 
> Approved, subject to one caveat:
> instead of
>   bool found_ini;
>   found_ini = do_fromcwd ()..
>   if (found_ini)
> 
> please use
>    if (do_fromcwd(...)) {
> 
> unneeded temporary variables are annoying.

Committed, with the above change.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]