This is the mail archive of the
mailing list for the Cygwin project.
Re: [Review - Good to go] suite3270
- From: "Peter A. Castro" <doctor at fruitbat dot org>
- To: cygwin-apps at cygwin dot com
- Date: Mon, 1 Dec 2003 20:52:45 -0800 (PST)
- Subject: Re: [Review - Good to go] suite3270
On Sun, 30 Nov 2003, Harold L Hunt II wrote:
> Harold L Hunt II wrote:
> > Peter,
> > Peter A. Castro wrote:
> >> Hi Harold,
> >> I've fixed item #2 concerning the install phase of building. As
> >> discussed, issue #1 will be left, as is, as it does not effect the
> >> packaging process. If you would, please re-pull from the same URLs and
> >> re-test/review. Thanks!
> > Okay, I just rebuilt the package. Here is my review:
> > Good to go!
> > The only question I have before uploading is how the files need to be
> > laid out. You gave a flat-file structure below, whereas we will
> > probably need something more like:
> > suite3270/setup.hint
> > suite3270/suite3270-3.2.20-1.tar.bz2
> > suite3270/suite3270-3.2.20-1-src.tar.bz2
> > suite3270/pr3287/pr3287-3.2.20-1.tar.bz2
> > suite3270/pr3287/setup.hint
> > suite3270/s3270/s3270-3.2.20-1.tar.bz2
> > suite3270/s3270/setup.hint
> > suite3270/tcl3270/setup.hint
> > suite3270/tcl3270/tcl3270-3.2.20-1.tar.bz2
> > suite3270/x3270/setup.hint
> > suite3270/x3270/x3270-3.2.20-1.tar.bz2
That's what I was thinking of too.
> Ugh... I just noticed that your all command is as follows:
> all) prep && conf && build && install && \
> pkg && spkg && finish ; STATUS=$? ;;
> You don't have a 'strip' command in there; I checked the s3270 package
> and noticed that s3270.exe is 484 KiB, versus 170 KiB after running it
> through 'strip'.
Ya, I just caught that myself while examine something unrelated. I've
just fix it and have updated the links.
> I suggest fixing this by adding 'strip' to the 'all' command and
> re-running the 'all' command. I will upload the package tomorrow after
> you have posted a stripped version.
I've got upload privs myself, so no need to do that (unless you *really*
want to :) Besides, I think the package is still missing a vote or two
(at least according to Daniel's latest PPL, no? ).
Peter A. Castro <firstname.lastname@example.org> or <Peter.Castro@oracle.com>
"Cats are just autistic Dogs" -- Dr. Tony Attwood