Re: New patch for generic-build-script

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

On Wed, 18 Feb 2004, Yaakov Selkowitz wrote:

> Igor,
>
> OK, here's the patch again, along with my ChangeLog.  Feel free to edit
> as necessary.
>
> Yaakov
>
>
> 2004-02-17  Yaakov Selkowitz <yselkowitz AT users DOT sourceforge DOT net>
>
>         * generic-build-script: Add 'configure', 'make', and 'test'
>         arguments as aliases for 'conf', 'build', and 'check'
>         respectively.  Add 'first' argument that calls mkdir(), spkg(),
>         and finish().  Add checksig() to beginning of 'all' sequence.
>         (install_docs): Add ABOUT-NLS, FAQ, THANKS.
>         (SIG): Define as 1 (on by default).
>         (reconf): New function for clean reconfigure.
>         (install): Clean ${instdir} before install.  Automatically gzip
>         info and man pages, if present.  Code cleanup.
>         (list): Simplify sed expression.
>         (depend): New function for listing runtime dependencies of
>         package executables and libraries.
>         (strip,mkpatch): Remove redirection of output to /dev/null.
>         (spkg): Improve readability.  Change test of ${SIG} to equality.
>         (checksig): Change order to ORIGINAL PACKAGE, SCRIPT, PATCH.
>         Change test of ${SIG} to equality.

Yaakov,

This looks good.  The only two comments I have are:

1) You replaced '&&'s by ';' after 'fi's in install() (where they were
needed), and left the one after 'find' in mkpatch() (where it was not).
This is minor, and I edited the patch accordingly[*] -- just letting you
know to expect conflicts with your local copy after the patch is applied.

2) Did you really mean to turn package signing on by default?  I, for
example, don't use package signing for my packages, and don't even have
GPG installed.  I'd rather the default setting was to not sign the
packages, and signing could be turned on on a package-by-package basis.
If you don't mind, I'll change that '1' to a '0' for now (please speak up
if you disagree).  Alternatively, we could check for the existence of
/usr/bin/gpg as one of the factors for turning on package signing,
something like 'SIG=`[ ! -x /usr/bin/gpg ]; echo $?`', but that could come
in a later patch.

Once you respond to this, I'll apply the patch.  Thanks for contributing.
	Igor
[*] FYI, here are the diffs between the edited patch and the original:

@@ -44,7 +44,7 @@
 	TODO \
 "
 export test_rule=test
-+export SIG=1   #set to 0 to turn off signing by default
++export SIG=0  #set to 1 to turn on signing by default

 # helper function
 # unpacks the original package source archive into ./${BASEPKG}/
@@ -75,12 +75,12 @@
   done &&\
+  if [ -d ${instdir}${prefix}/share/info ] ; then \
+    find ${instdir}${prefix}/share/info -name "*.info" | xargs gzip -q ; \
-+  fi ; \
++  fi && \
+  if [ -d ${instdir}${prefix}/share/man ] ; then \
+    find ${instdir}${prefix}/share/man -name "*.1" -o -name "*.3" -o \
+      -name "*.3x" -o -name "*.3pm" -o -name "*.5" -o -name "*.6" -o \
+      -name "*.7" -o -name "*.8" | xargs gzip -q ; \
-+  fi ; \
++  fi && \
   templist="" && \
   for f in ${install_docs} ; do \
     if [ -f ${srcdir}/$f ] ; then \
@@ -126,7 +126,7 @@
 mkpatch() {
   (cd ${srcdir} && \
-  find . -name "autom4te.cache" | xargs rm -rf > /dev/null ; \
-+  find . -name "autom4te.cache" | xargs rm -rf && \
++  find . -name "autom4te.cache" | xargs rm -rf ; \
   unpack ${src_orig_pkg} && \
   mv ${BASEPKG} ../${BASEPKG}-orig && \
   cd ${topdir} && \

--
				http://cs.nyu.edu/~pechtcha/
     |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
    |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
   '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton