This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] setup: increase tooltip delay for larger tooltips


On Wed, 7 Sep 2005, Eric Blake wrote:

> > I have updated the Cygwin setup utility to version 2.510.2.1.
> [snip]
> Minor bugs I have noticed:
> [snip]
> The tooltip for the View button disappears before I have had a
> chance to finish reading it, since it contains so much text.

The attached patch increases tooltip limits for tooltips larger than 80
characters, proportionally to the extra size.  The delay calculation is
rather arbitrary -- I got about 20 seconds on the tooltip Eric complained
about.

Note: I think the maximum tooltip delay is 32768ms -- anything larger than
that was ignored (this is undocumented, but may be implied by
LPARAM==short).  That's the reason for the 0.5 factor in the delay
calculation.  To make the code more robust, we should probably test for
overflow and max out at some value.

As usual, the ChangeLog is below.
	Igor
==============================================================================
ChangeLog:
2005-09-07  Igor Pechtchanski  <pechtcha@cs.nyu.edu>

	* window.h (Window::TooltipDisplayHandler): New member function.
	* window.cc (Window::TooltipDisplayHandler): Set delay proportional
	to tooltip length.
	* proppage.cc (PropertyPage::DialogProc): Call TooltipDisplayHandler
	for TTN_SHOW notifications.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA

Attachment: setup-tooltip-delay.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]