This is the mail archive of the
mailing list for the Cygwin project.
RE: [PATCH] setup: fix abnormal exit test for postinstall scripts
- From: "Dave Korn" <dave dot korn at artimi dot com>
- To: <cygwin-apps at cygwin dot com>
- Date: Thu, 9 Mar 2006 23:29:26 -0000
- Subject: RE: [PATCH] setup: fix abnormal exit test for postinstall scripts
On 09 March 2006 23:14, Max Bowsher wrote:
>>> * script.cc (Script::run): Fix inverted test for abnormal exit.
>>> Do not rename to ".done" unless completed successfully.
>> And ping (attached as "setup-script-exit-code-fix.patch").
> Do we necessarily want to try to re-run failed scripts the next time
> setup installs some packages?
> Perhaps renaming to ".failed" would be better that not renaming.
Perhaps setup should check when you first start it up whether there are any
postinstall scripts left lying around from last time and offer to run them for
you then and there? Failed postinstalls should be run to completion *before*
next updating the package!
Can't think of a witty .sigline today....