This is the mail archive of the
mailing list for the Cygwin project.
RE: [PATCH] setup: replace radiobuttons on chooser
- From: "Dave Korn" <dave dot korn at artimi dot com>
- To: <cygwin-apps at cygwin dot com>
- Date: Wed, 15 Mar 2006 19:41:10 -0000
- Subject: RE: [PATCH] setup: replace radiobuttons on chooser
On 14 March 2006 16:20, Dave Korn wrote:
> On 14 March 2006 16:03, Max Bowsher wrote:
>> Dave Korn wrote:
>>> The radiobuttons for Prev, Keep, Curr, Exp at the top of the package
>>> chooser should never have been radiobuttons. They don't select a
>>> persistent mode, they perform an instantaneous action. Action buttons
>>> should be pushbuttons. Hence this patch changes them to pushbuttons.
>> They seem to have BOTH an instantaneous AND a persistent influence,
>> actually - so I'd prefer to keep using controls which display the
>> current state.
> Huh? AYS? As far as I can see, there is code in
> ChooserPage::OnMessageCmd that responds to clicking any given one by calling
> keepClicked() or changeTrust(xxx), and there's nothing else anywhere else
> that could query or in any way respond to the state of the buttons or that
> tests which one is checked or anything. Why do you say they have a
> persistent influence? I'm /very/ convinced that they change the state of
> the selection when clicked and it's a one-shot, what bit of the code are
> you looking at that suggests otherwise?
Max, ping? Have you looked at this? If I don't hear from you in the next
few hours I'll check in part 2 of the patch on its own like you asked, but I'm
still convinced part 1 is good as well.
Can't think of a witty .sigline today....