RE: [PATCH] Two fixes for setup postinstall handling.

["Dave Korn" <dave dot korn at artimi dot com>]

Brian Dessent wrote on 10 August 2008 20:51:

> Christopher Faylor wrote:
> 
>> If this is necessary, I don't like the idea of special casing bash.
>> Can't we add a keyword to setup.ini so this could be configurable?
> 
> I don't like this either.  I feel it's not necessary.  If we just fix
> the setup.hints for any packages that have postinstalls but don't list
> bash in "requires:" then this problem goes away, 

  Until next time.  Then we have to go through this all over again.

> and it is a fix that
> works with any version of setup without requiring any user upgrades.

  I did a crude estimate.

  I used the package-grep feature to find all packages which unpack any
files into etc/postinstall.  Then I fetched their setup hints and grepped
the requires line for bash.

  This is subject to false positives, as it may be an old version (package
grep returns all versions) that had the postinstall script and setup.hint
correctly now doesn't mention bash because the newer package versions lose
the postinstall.  Hoever, as a ball park figure:

  30 packages have it right.  202 have it wrong.

  This suggests to me that relying on a manual system is not working.

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....