This is the mail archive of the
mailing list for the Cygwin project.
GOLD STAR please (was Re: [PATCH] inform user if any postinstall script) failed to run
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 4 Aug 2010 16:22:37 -0400
- Subject: GOLD STAR please (was Re: [PATCH] inform user if any postinstall script) failed to run
- References: <4C49D54B.firstname.lastname@example.org> <20100723184920.GB9768@ednor.casa.cgf.cx> <4C503DCD.email@example.com> <20100728145822.GA9785@ednor.casa.cgf.cx> <4C51AC12.firstname.lastname@example.org> <20100730143740.GA30877@ednor.casa.cgf.cx> <4C5325B8.email@example.com>
- Reply-to: cygwin-apps at cygwin dot com
Could I get a gold star for this change? It fixes a longstanding annoyance.
Also, one each for Jon and Andy for fixing other problems.
On Fri, Jul 30, 2010 at 08:19:20PM +0100, Dave Korn wrote:
>On 30/07/2010 15:37, Christopher Faylor wrote:
>> errors" page. The only two packages that should have been installed
>> gcc: C compiler upgrade helper
>> glib: Gnome C function library (1.2 sources)
>> (both of which are selected due to a setup.exe bug)
> I finally got bored of this one. Turned out to be trivially easy to fix
>once I looked at it, it's simply an early exit from the install routine when
>there's nothing to do for a dummy tarball (zero or 46-byte size) that misses
>out on marking the package as installed.
> * install.cc (Installer::installOne): Also record zero-sized
> tarballs as successfully installed.
>RCS file: /cvs/cygwin-apps/setup/install.cc,v
>retrieving revision 2.95
>diff -p -u -r2.95 install.cc
>--- install.cc 7 Apr 2010 11:40:02 -0000 2.95
>+++ install.cc 30 Jul 2010 18:48:19 -0000
>@@ -301,7 +301,10 @@ Installer::installOne (packagemeta &pkgm
> error condition.
> Same goes for tar archives consisting of a big block of
> all zero bytes (the famous 46 bytes tar archives). */
>+ if (ver.Type () == package_binary)
>+ pkgm.installed = ver;
> note (NULL, IDS_ERR_OPEN_READ, source.Cached (),