This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] Stop automatic dependency selection on setup.exe chooser screen
On 6 August 2010 21:36, Christopher Faylor wrote:
> On Fri, Aug 06, 2010 at 10:26:02PM +0200, Corinna Vinschen wrote:
>>Here's another test with only selecting the vorbis-tools package.
>>With the current setup from CVS:
>>
>> ÂPackage: libao4
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libFLAC8
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libkate1
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libogg0
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libspeex1
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libvorbis0
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libvorbisenc2
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libvorbisfile3
>> Â Â Â Â Required by: vorbis-tools
>>
>>With my patch:
>>
>> ÂPackage: libao
>> Â Â Â Â Required by: libao4
>>
>> ÂPackage: libao-devel
>> Â Â Â Â Required by: libao
>>
>> ÂPackage: libao4
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libaudio2
>> Â Â Â Â Required by: libao4
>>
>> ÂPackage: libaudiofile0
>> Â Â Â Â Required by: libesd0
>>
>> ÂPackage: libesd0
>> Â Â Â Â Required by: libao4
>>
>> ÂPackage: libFLAC8
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libkate
>> Â Â Â Â Required by: libkate1
>>
>> ÂPackage: libkate1
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libogg0
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libspeex1
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libvorbis
>> Â Â Â Â Required by: libvorbis0
>>
>> ÂPackage: libvorbis0
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libvorbisenc2
>> Â Â Â Â Required by: vorbis-tools
>>
>> ÂPackage: libvorbisfile3
>> Â Â Â Â Required by: vorbis-tools
>>
>>
>>Looks still good, doesn't it?
>
> Yep. ÂAndy do you agree?
I'm still working on a patch that tries to address this without a
second dependency checking loop, by putting all desired packages into
a todo list at the start, and then adding to it as we go through it
and find missing dependencies.
But since Corinna got there first ... . Doesn't the first loop need a
(*n).first->prereq_checked (true) as well though?
Andy