This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] Add the last element of URL path to site chooser, if interesting.


On Fri, Dec 10, 2010 at 06:41:19PM +0000, Jon TURNEY wrote:
>On 29/11/2010 12:57, Corinna Vinschen wrote:
>> On Nov 26 13:48, Jon TURNEY wrote:
>>> Currently, for example, if I manually add the site http://mirrors.kernel.org/sources.redhat.com/cygwinports/
>>> to setup's mirror list, I get two indistinguishable entries named http://mirrors.kernel.org.
>>>
>>> Furthermore, because the code to ensure the site just added is selected uses the string inside the list control
>>> to locate elements, we end up with a random one of those two indistinguishable entries selected (usually the
>>> previously existing one).
>>>
>>> This problem also prevents the selected sites being correctly saved and restored for the next setup run.
>>>
>>> So, to make the site chooser list entries unique and distinguishable, add the last element of the URL path to
>>> the site chooser, if it exists and isn't 'cygwin' (or some other alternatives used by current mirrors)
>> 
>> That sounds a bit problematic.  So two URLs on the same machine might
>> again end up as the same string, undistinguishable, just because they
>> both end in the same directory name?
>
>Yes, this is true, but currently *any* two URLs on the same host are
>indistinguishable.
>
>> And there are (right now) four
>> such directory names, which are treated identically.
>
>I'm sorry, I don't understand what you are referring to here.
>
>> Don't get me wrong.  It's certainly better than what we have today,
>> and the full URL is almost unreadable.  Nevertheless, I'd be more happy
>> with a solution which fixes this problem even for such border cases...
>
>Back to the bikeshed, then :-)
>
>If we were starting from scratch, how would this work?

If we were doing this from scratch then I think we should present a tree view by

country
  region
    site
      protocol dir

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]