This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [patch/rebase] rebaseall: Set default offset to 0
- From: Charles Wilson <cygwin at cwilson dot fastmail dot fm>
- To: Mailing List: CygWin-Apps <cygwin-apps at cygwin dot com>
- Date: Tue, 28 Jun 2011 13:37:10 -0400
- Subject: Re: [patch/rebase] rebaseall: Set default offset to 0
- References: <20110628162913.GH9552@calimero.vinschen.de>
- Reply-to: Charles Wilson <cygwin at cwilson dot fastmail dot fm>
On 6/28/2011 12:29 PM, Corinna Vinschen wrote:
> Index: rebaseall.in
> ===================================================================
> RCS file: /sourceware/projects/cygwin-apps-home/cvsfiles/rebase/rebaseall.in,v
> retrieving revision 1.2
> diff -u -p -r1.2 rebaseall.in
> --- rebaseall.in 21 Jun 2011 15:40:10 -0000 1.2
> +++ rebaseall.in 28 Jun 2011 16:29:06 -0000
> -DefaultOffset=0x10000
> +DefaultOffset=0
> DefaultVerbose=
> DefaultFileList=
> DefaultSuffixes='dll|so'
I'd prefer that this be set via a configure replacement. On MSYS and
MinGW (really, MSYS) we need to stick with the old default offset, since
on that system we still have to worry about the extra allocated space.
('sokay, tho, 'cause we have FAR fewer dlls to worry about, and can
afford the space).
e.g.
configure.ad
case $host in
*mingw* | *msys* ) DEFAULT_OFFSET_VALUE=0x10000
*) DEFAULT_OFFSET_VALUE = 0x0
esac
AC_SUBST(DEFAULT_OFFSET_VALUE)
and then
-DefaultOffset=0x10000
+DefaultOffset=@DEFAULT_OFFSET_VALUE@
--
Chuck