Ken Brown writes:
Were the new setup programs built from what's currently at your Git
repo? If so, I have a couple of very minor comments:
Except for the addition of .cmd as an alias for .bat, yes.
- // Look for any scripts in /etc/postinstall which haven't been renamed .done
- std::string postinst = cygpath ("/etc/postinstall");
+ // Look for runnable non-perpetual scripts in /etc/postinstall
+ // this shouldn't happen (leftovers from the previous install?)
This comment is slightly misleading. It would be clearer to say
something like, "This happens when a script from a previous install
failed to run successfully."
Thanks, that's more clear.
+Script::Script (const std::string& fileName)
[...]
+ if ( 2 == scriptBaseName.find('_') &&
+ 0 == scriptBaseName.substr(1,1).find_first_of(allowedTypes) &&
+ "_" != scriptBaseName.substr(0,1)
This last test is redundant, since we already know that 2 ==
scriptBaseName.find('_').
No it isn't, this last test kicks out scripts that attempt to be run at
the default stratum by making their first character an underscore, like
_p_whatever.sh -- these aren't supposed to exist. The first test checks
the third character