This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's
- From: Eric Blake <eblake at redhat dot com>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 7 Feb 2018 09:38:46 -0600
- Subject: Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's
- Authentication-results: sourceware.org; auth=none
- References: <59D90AF8D70E9740907BACDE2BCB520836E4AA63@RESW102.resdom01.local> <20180206142012.GB30794@calimero.vinschen.de> <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com> <af20a08b-f826-d2ff-fe93-cf6a72677aa5@maxrnd.com>
On 02/07/2018 01:29 AM, Mark Geisert wrote:
I don't have libtirpc in git so I'm submitting a text patch. Sorry for
any inconvenience. This is Cygwin-specific and against
src/bindresvport.c of libtirpc 1.0.1. Unsure if it ought to go
upstream; appreciate input on that.
Thanks much,
..mark
--------8<--------
35a36,38
> /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version
here */
An ed-script diff is practically useless; without context, it is too
easy to misapply the patch if the file has been edited differently in
the meantime. ALWAYS use 'diff -u' (what git does by default) or 'diff
-c' when generating a patch, so that it has proper context.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org