This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
[PATCH setup v2 2/2] Fix detection of automatically added packages
- From: Ken Brown <kbrown at cornell dot edu>
- To: cygwin-apps at cygwin dot com
- Date: Thu, 7 Jun 2018 13:37:24 -0400
- Subject: [PATCH setup v2 2/2] Fix detection of automatically added packages
- References: <20180607173724.5972-1-kbrown@cornell.edu>
In the "confirm" dialog, report a package as automatically added for
install if the version being installed is different from the version
requested by the user. This can happen if the global update mode is
"Keep" but a package needs to be updated because of a versioned
dependency.
---
confirm.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/confirm.cc b/confirm.cc
index cd749c0..d0a8420 100644
--- a/confirm.cc
+++ b/confirm.cc
@@ -109,7 +109,7 @@ ConfirmPage::OnActivate()
line += i->version.Canonical_version();
if (i->version.Type() == package_source)
line += " (source)";
- else if (pkg && !pkg->desired)
+ else if (pkg && pkg->desired != pv)
line += " (automatically added)";
line += "\r\n";
install.push_back (line);
--
2.17.0