Re: [PATCH setup] Avoid stringop-overflow warning with gcc8

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Oct 13 13:50, Jon Turney wrote:
> On 12/10/2018 16:58, Corinna Vinschen wrote:
> > On Oct 12 16:43, Jon Turney wrote:
> [...]
> > > diff --git a/desktop.cc b/desktop.cc
> > > index 927c02f..d003e91 100644
> > > --- a/desktop.cc
> > > +++ b/desktop.cc
> > > @@ -107,7 +107,8 @@ start_menu (const std::string& title, const std::string& target,
> > >   			      issystem ? CSIDL_COMMON_PROGRAMS :
> > >   			      CSIDL_PROGRAMS, &id);
> > >     SHGetPathFromIDList (id, path);
> > > -  strncat (path, "/Cygwin", MAX_PATH);
> > > +  strncat (path, "/Cygwin", MAX_PATH - strlen(path));
> > 
> > Shouldn't that be
> > 
> >       strncat (path, "/Cygwin", MAX_PATH - strlen(path) - 1);
> > 
> > ?
> 
> Yes!  I have no idea what I was thinking!

Better than the crime I have commited originally...


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature