This is the mail archive of the
cygwin-cvs@cygwin.com
mailing list for the Cygwin project.
[newlib-cygwin] cygcheck: Close with pclose what has been opened with popen
- From: Corinna Vinschen <corinna at sourceware dot org>
- To: cygwin-cvs at sourceware dot org
- Date: 22 Oct 2016 20:53:59 -0000
- Subject: [newlib-cygwin] cygcheck: Close with pclose what has been opened with popen
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=46c472a1c15a61af1db656f6b55af9b4e5e450d6
commit 46c472a1c15a61af1db656f6b55af9b4e5e450d6
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Sat Oct 22 22:14:34 2016 +0200
cygcheck: Close with pclose what has been opened with popen
Fixes Coverity CID 66900
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/utils/cygcheck.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/utils/cygcheck.cc b/winsup/utils/cygcheck.cc
index f6adf51..c9eb8a6 100644
--- a/winsup/utils/cygcheck.cc
+++ b/winsup/utils/cygcheck.cc
@@ -1192,7 +1192,7 @@ dump_sysinfo_services ()
puts ("The version of cygrunsrv installed is too old to dump service info.\n");
return;
}
- fclose (f);
+ pclose (f);
/* For verbose mode, just run cygrunsrv --list --verbose and copy output
verbatim; otherwise run cygrunsrv --list and then cygrunsrv --query for