This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Some "interesting" changes checked in

To: cygwin-developers at cygwin dot com
Subject: Re: Some "interesting" changes checked in
From: Christopher Faylor <cgf at redhat dot com>
Date: Tue, 6 Mar 2001 16:25:56 -0500
References: <20010305013457.A1344@redhat.com> <20010306140641.D7734@cygbert.vinschen.de>
Reply-To: cygwin-developers at cygwin dot com

On Tue, Mar 06, 2001 at 02:06:41PM +0100, Corinna Vinschen wrote:
>The error is in suffix_scan::has. The order of the conditionals
>disallows .lnk suffixes for input files when in_suffixes is NULL.
>
>I have checked in a patch.

Thanks.  I had a hard time with that particular logic.  I'm still
not satisfied with it.  It seems to be scanning the suffix list
too often but I can't think of any way to avoid this.

Your patch is obviously correct, though.

I've redesigned suffix scanning almost as often as I've redesigned
signals.  And I still don't seem to have either quite right.  Sigh.

cgf

References:
- Some "interesting" changes checked in
  - From: Christopher Faylor
- Re: Some "interesting" changes checked in
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]