Re: SHOWSTOPPER: [was Re: vfscanf in newlib]

["Robert Collins" <robert dot collins at itdomain dot com dot au>]

----- Original Message -----
From: "Corinna Vinschen" <vinschen@redhat.com>
To: "Corinna Vinschen" <cygwin-developers@cygwin.com>
Sent: Monday, April 23, 2001 7:13 AM
Subject: Re: SHOWSTOPPER: [was Re: vfscanf in newlib]


> On Sun, Apr 22, 2001 at 10:33:17PM +0200, Corinna Vinschen wrote:
> > On Sat, Apr 21, 2001 at 01:38:58PM -0400, Charles S. Wilson wrote:
> > > > On Sat, Apr 21, 2001 at 01:21:30AM -0400, Charles Wilson wrote:
> > > > > I've just discovered that I get a coredump with all three when
I try to
> > > > > run ssh.  #$!@&$
> > > >
> > > > I just build the latest from CVS and it's running fine, even ssh
and
> > > > sshd.
> > > >
> > > > Corinna
> > >
> > > Thank you.  I guess that means the answer from my email is #3:
I've
> > > somehow lost the ability to build a working cygwin snapshot from a
> > > perfectly good codebase.  Funny, I don't remember the surgeon
saying
> > > "Ooops" during my recent brain surgery.... :-)
> >
> > Sorry Chuck, it seems I haven't tried to build from the latest
sources.
> > You're right, the latest code fails to run sshd. It dies with an
access
> > violation on each connect.
> >
> > I tracked it down to Robert's changes. Somewhere here:
> > [...]
> >         * passwd.cc (getpwuid): Check for thread cancellation.
> >         (getpwuid_r): Ditto.
> >         (getpwname): Ditto.
> >         (getpwnam_r): Ditto.
>
> The above four calls to pthread_testcancel() are the problem. I've
> further tracked them down to the __pthread_testcancel() function.
> The following patch solves the problem.
>
> Robert? Chris? Ok to checkin?
>

Fine here. I'm surprised that pthread_self() is ever returning NULL
though!.

Rob