This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
Re: small_print vs system_printf
- From: Christopher Faylor <cgf at redhat dot com>
- To: cygwin-developers at cygwin dot com
- Date: Tue, 2 Jul 2002 23:19:49 -0400
- Subject: Re: small_print vs system_printf
- References: <057b01c2223e$4977cd20$6132bc3e@BABEL>
- Reply-to: cygwin-developers at cygwin dot com
On Wed, Jul 03, 2002 at 04:04:02AM +0100, Conrad Scott wrote:
>I've just noticed that in various places in the DLL, small_print is
>called directly. Most of these look (to me) like they should be using
>system_printf; for example, in tty.cc (reformatted slightly):
>
> if (wincap.has_security ()
> && cygserver_running==CYGSERVER_OK
> && (SetKernelObjectSecurity (hMainProc,
> ACL_SECURITY_INFORMATION,
> get_null_sd ()) == FALSE))
> small_printf ("Can't set process security, %E");
>
>Would a patch to change (all of?) these uses to system_printf be
>accepted?
I only see a couple of these that I think should be changed. I checked
in a fix to eliminate them.
Thanks for the heads up.
cgf