This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] change to thread.cc -- need feedback


On Tue, 2002-10-01 at 01:12, Christopher Faylor wrote:
> I've changed the static declarations in thread.cc to use
> NO_COPY and things seem to be working better in my build.

Ah yes, good thing. 
 
> In doing this, I noticed that a CreateEvent and a CreateMutex were using
> a default argument 1 (security attributes).
> 
> I changed these to an explicit "no inherit" but I'm not 100% sure
> that this is the right thing to do in all cases.

The MS Doco for createMutex says that a default argument results in a
non inheritable mutex. so in theory, it's the right thing.
 
> Could someone who is familiar with the code (Robert?, Thomas?) look
> at the patch below and, if I got it wrong, fix this so that the
> handles will be properly inherited, if required?

Please commit this.

Rob
-- 
---
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.
---

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]