This is the mail archive of the cygwin-developers mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: just made a change I didn't like to strfmon.c


On Jan 29 19:03, Corinna Vinschen wrote:
> On Jan 29 12:40, Christopher Faylor wrote:
> > @@ -429,7 +430,7 @@ __setup_vars(int flags, char *cs_precede
> >                 *cs_precedes = lc->n_cs_precedes;
> >                 *sep_by_space = lc->n_sep_by_space;
> >                 *sign_posn = (flags & PARENTH_POSN) ? 0 : lc->n_sign_posn;
> > -               *signstr = (lc->negative_sign == '\0') ? "-"
> > +               *signstr = (lc->negative_sign == NULL) ? negative

I think the fix is wrong, btw.  The string members of the struct
returned by localeconv are supposed to be never NULL.  This is a test
for an empty string which is suffering from a typo, the missing '*'.

Are you going to fix it or shall I?


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]