RE: [PATCH] Move per_thread::set() def from fork.cc to perthread.h

["Gary R. Van Sickle" <g dot r dot vansickle at worldnet dot att dot net>]

> -----Original Message-----
> From: cygwin-patches-owner@sources.redhat.com
> [mailto:cygwin-patches-owner@sources.redhat.com]On Behalf Of Christopher
> Faylor
> Sent: Monday, October 15, 2001 6:32 PM
> To: cygwin-patches@cygwin.com
> Subject: Re: [PATCH] Move per_thread::set() def from fork.cc to
> perthread.h
>

[snip]

> >Ah, good point.  Do you have any objections then to a perthread.cc?
>
> I guess not in principle but it seems kind of pointless for one
> function.

It would be, so what I did was move much of the implementation of
per_thread, per_thread_waitq, per_thread_vfork, and
per_thread_signal_dispatch into it (just the virtuals right now).

>  And, it would be enough of a patch that I'd need an
> assignment from you.  I don't think we have an assignment on file from
> you, do we?
>

No, do you want to fax me one?

> I'm actually thinking that maybe it *should* just live in the header.
> I think I might have moved it to fork.cc when I was debuging it.
>

Well, ok, you have that patch.  But I agree with Robert and you of two days
ago ;-), the implementation really belongs in a .cc file, not the .h.  And
there's always more code to write, and more problems to debug.

So I guess just let me know, I've got it written and added to Makefile.in
and everything's working fine.

> cgf
>