This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Update 2 - Setup.exe property sheet patch

From: "Robert Collins" <robert dot collins at itdomain dot com dot au>
To: "Gary R. Van Sickle" <g dot r dot vansickle at worldnet dot att dot net>,<cygwin-patches at sourceware dot cygnus dot com>
Date: Fri, 21 Dec 2001 00:05:50 +1100
Subject: Re: [PATCH] Update 2 - Setup.exe property sheet patch
References: <NCBBIHCHBLCMLBLOBONKIEAFCIAA.g.r.vansickle@worldnet.att.net>

Having had a good close look, there is a little more that is needed
before committing to CVS.

1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what
was breaking local_dir. (Oh, and the functions weren't virtual in some
child classes :}).
2) See download.cc - is next_dialog still used, and should a fail result
in the previous behaviour?

I've attached an updated patch for you with the virtual functions
actually still virtual.

Rob

Attachment: Gary2.patch.bz2
Description: Binary data

Follow-Ups:
- RE: [PATCH] Update 2 - Setup.exe property sheet patch
  - From: Gary R Van Sickle

References:
- [PATCH] Update 2 - Setup.exe property sheet patch
  - From: Gary R. Van Sickle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]