This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] minor pthread fixes



> -----Original Message-----
> From: cygwin-patches-owner@cygwin.com 
> [mailto:cygwin-patches-owner@cygwin.com] On Behalf Of Corinna Vinschen
> Sent: Wednesday, 5 June 2002 11:09 PM
> To: cygwin-patches@cygwin.com
> Subject: Re: [PATCH] minor pthread fixes
> 
> 
> On Wed, Jun 05, 2002 at 10:44:54PM +1000, Robert Collins wrote:
> > Ok, Chris, whats the guideline in nuber-of-line before we need an
> > assignment? Do I need to back out this patch (it's very few 
> lines, just
> > spread over a few functions).
> 
> I'm not Chris, sorry

That's ok, you being a RedHat employee and all :}.

> , but the answer is basically something below
> 10 changed lines is treated as "nonsignificant".  There's no hard
> rule, though.  Basically, if a change is not only fixing a bug but
> introduces new functionality, it's a "significant" patch, even if
> it's changing less than 10 lines.

Hmm. I'll look carefully at the remaining patches to see if there is new
functionality or just bugfixes. The current one should be fine though
IMO.

Rob


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]