This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: qt patch for winnt.h
Christopher Faylor wrote:
On Thu, Jul 25, 2002 at 11:29:20AM -0400, Nicholas Wourms wrote:
2002-07-25 Nicholas Wourms <nwourms@netscape.net>
* winnt.h (HANDLE): Add guard for compiling qt.
I really think this sets an incredibly bad precedent. Littering the
system headers with project specific defines is really distasteful
to me.
Ok,
Perhaps you would prefer this better. I changed the ifdef to be
feature-centric as opposed to project-centric. Perhaps this is a little
more to your liking?
Cheers,
Nicholas
2002-07-25 Nicholas Wourms <nwourms@netscape.net>
* winnt.h (HANDLE): Allow uint type for HANDLE.
Index: winnt.h
===================================================================
RCS file: /cvs/src/src/winsup/w32api/include/winnt.h,v
retrieving revision 1.52
diff -u -3 -p -u -p -r1.52 winnt.h
--- winnt.h 17 Jul 2002 03:37:45 -0000 1.52
+++ winnt.h 25 Jul 2002 15:09:11 -0000
@@ -108,7 +108,11 @@ typedef const TCHAR *LPCTSTR;
#define TEXT(q) __TEXT(q)
typedef SHORT *PSHORT;
typedef LONG *PLONG;
+#ifndef WINNT_H_UINT_HANDLE /* Allow uint typedef for HANDLE */
typedef void *HANDLE;
+#else
+typedef unsigned int HANDLE;
+#endif /* WINNT_H_UINT_HANDLE */
typedef HANDLE *PHANDLE,*LPHANDLE;
#ifdef STRICT
#define DECLARE_HANDLE(n) typedef struct n##__{int i;}*n