This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: SIOCGIFCONF patch


On Sat, Nov 09, 2002 at 08:28:39PM +0100, Alexander Gottwald wrote:
> Hi,
> 
> A user of Cygwin/Xfree86 reported that cygwin did not report an interface
> for his wireless network adapter. It seems that the GetIfTable function
> did not return all network adapters on his computer. As a workaround to
> this problem i changed the code to use GetIfEntry for each configured
> address. 
> 
> I also had to change the algorithm for finding all addresses configured
> for one network adapter and changed the previous code which could only
> enumerate 10 addresses per adapter to use sprintf and raised that limit too.

This part of the patch is fine.

> I also added code for getting the device metric for an interface. I'm 
> not sure if this is correctly solved and I have no problems with removing 
> this part again. 

As I wrote in PM yesterday, I think it's incorrect to get the IF metric
from the routing entry.  It's the other way around according to the
doc excerpt which you did friendly send to me.  So, I actually would like
to ask you to take this part out.  As soon as you send the tweaked patch,
I'll check it in.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]