This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: {Patch]: Giving access to pinfo after seteuid and exec


At 10:23 PM 9/25/2003 -0400, you wrote:
>On Thu, Sep 25, 2003 at 10:17:22PM -0400, Christopher Faylor wrote:
>>I'll check in the rest of the spawn.cc stuff with some modifications.  I see
>>I missed some cases with the addition of _P_SYSTEM.
>
>I'm sorry.  Long day.  I'm checking in the non-acl related stuff.  I'll leave
>the rest for Corinna's review.
>
OK.

By the way, in the case      
if (!child)
	{
	  syscall_printf ("pinfo failed");
	  set_errno (EAGAIN);

the EAGAIN is masking the true reason that should have been set by the
pinfo code. That may be Posix, but it's not helpful from a debugging
point of view.

If you still have some energy, in fork.cc the "pinfo forked"
should be checked for error as well.

Pierre



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]