This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Truncate


At 11:37 AM 8/28/2004 +0200, Corinna Vinschen wrote:
>Hi Pierre,
>
>On Aug 27 21:42, Pierre A. Humblet wrote:
>> At 01:00 PM 8/23/2004 +0200, Corinna Vinschen wrote:
>> >Except for this comment, which isn't valid (see above), please check it
in.
>> 
>> Done. But here is another simple patch taking care of your concern that
>> we can fail while zero filling, leaving the file system filled to capacity.
>> 
>> 2004-08-28  Pierre Humblet <pierre.humblet@ieee.org>
>> 
>> 	* fhandler.cc (fhandler_base::write): In the lseek_bug case, set EOF
>> 	before zero filling. Combine similar error handling statements. 
>
>the first part of the patch is ok, but somehow the new `goto' looks
>somewhat weird to me.  What about this instead:

<snip>

Sure. Will you apply it?

Pierre
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]