This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Truncate


On Aug 28 10:07, Pierre A. Humblet wrote:
> At 11:37 AM 8/28/2004 +0200, Corinna Vinschen wrote:
> >On Aug 27 21:42, Pierre A. Humblet wrote:
> >> 	* fhandler.cc (fhandler_base::write): In the lseek_bug case, set EOF
> >> 	before zero filling. Combine similar error handling statements. 
> >
> >the first part of the patch is ok, but somehow the new `goto' looks
> >somewhat weird to me.  What about this instead:
> 
> <snip>
> 
> Sure. Will you apply it?

Please apply it.  It's still your patch, basically.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]