This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [Patch] Trailing spaces in cygcheck -cd or -s output.
- From: Bas van Gompel <cygwin-patches dot buzz at bavag dot tmfweb dot nl>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 23 Sep 2004 09:19:32 +0200 (MET DST)
- Subject: Re: [Patch] Trailing spaces in cygcheck -cd or -s output.
- Organisation: Ehm...
- References: <n2m-g.cibek2.3vvfqsr.1@buzzy-box.bavag> <20040922115453.GZ17670@cygbert.vinschen.de>
- Reply-to: <cygwin-patches mailing-list <cygwin-patches#cygwin dot com at green dot qinip dot net>
Op Wed, 22 Sep 2004 13:54:53 +0200 schreef Corinna Vinschen
in <20040922115453.GZ17670@cygbert.vinschen.de>:
: On Sep 16 07:26, Bas van Gompel wrote:
[dump_setup.cc (dump_setup): Avoid trailing spaces on package-list.]
: Thanks for the patch. I've applied the patch plus an additional patch which
: adds an `if (check_files)' to simplify the expressions in (now two) printf's.
Thanks, that's much more readable.
Now one can eliminate a spurious ``strlen'', as well.
ChangeLog-entry:
2004-09-23 Bas van Gompel <cygwin-patch.buzz@bavag.tmfweb.nl>
* dump_setup.cc (dump_setup): Remove unneeded strlen when check_files
is not set.
Patch:
--- src/winsup/utils/dump_setup.cc 22 Sep 2004 11:50:51 -0000 1.15
+++ src/winsup/utils/dump_setup.cc 23 Sep 2004 05:26:51 -0000
@@ -403,8 +403,8 @@ dump_setup (int verbose, char **argv, bo
check_package_files (verbose, packages[i].name)
? " OK" : " Incomplete");
else
- printf ("%-*s %-*s\n", package_len, packages[i].name,
- strlen(packages[i].ver), packages[i].ver);
+ printf ("%-*s %s\n", package_len, packages[i].name,
+ packages[i].ver);
fflush(stdout);
}
L8r,
Buzz.
--
) | | ---/ ---/ Yes, this | This message consists of true | I do not
-- | | / / really is | and false bits entirely. | mail for
) | | / / a 72 by 4 +-------------------------------+ any1 but
-- \--| /--- /--- .sigfile. | |perl -pe "s.u(z)\1.as." | me. 4^re