This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] cygcheck.cc update for cygpath()


On Mar 15 06:49, Brian Dessent wrote:
> Anyway, the attached is the result of what happened when I started with
> the Cygwin code and whittled it down.  It fixes the bug in the
> grandparent of this email where it was reading the Win32 path out of a
> shortcut that didn't have an ITEMIDLIST, and it supports the new-style
> shortcut where the target > MAX_PATH gets stored at the end.  It does
> not attempt to do anything with reparse points however.

That's ok.  We won't use reparse points for our own dreadful purposes
anyway.

> 	* path.cc: Include malloc.h for alloca.
> 	(is_symlink): Rewrite.  Just read the whole file in memory rather
> 	than by parts.  Account for an ITEMIDLIST if present, as well as
> 	the new style of Cygwin shortcut supporting targets > MAX_PATH.

The patch looks ok to me.  Please check it in.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]