This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0


Christopher Faylor wrote:
> On Mon, Aug 10, 2009 at 05:28:16AM +0100, Dave Korn wrote:

>>  My turn to say "ugh"!  The wrapper function would translate down to a single
>> 'jmp' if -fno-omit-frame-pointer was in effect, but as things stand it's a bit
>> ugly.  So maybe we should let both of these rest for a while and see how things
>> pan out upstream.
> 
> Yes, sometimes we do ugly things in Cygwin to avoid slowdowns, even if
> it is to avoid a simple "jmp".

  Sure.  So, let's leave this one out and wait for the bug to get fixed in GCC.

>>> Also, referring to a bug without explaining what the problem either in
>>> the source code or the ChangeLog is a guaranteed way to cause confusion
>>> tomorrow after a memory cache refresh.
>>  You mean the PR notation?  Hopefully GCC's bugzilla will still be there
>> tomorrow!  Anyway, with a bit of luck we won't end up needing this one at all.
> 
> Whether it is there tomorrow or not, we don't want to expect someone who
> reads source code to know where to go to look for a gcc bugzilla entry.

  Righto, will make a mental note for future patches.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]