This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1.7] bugs in faccessat


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Corinna Vinschen on 9/25/2009 2:11 AM:
>> +int __stdcall check_file_access (path_conv &, int, bool effective = true);
>> +int __stdcall check_registry_access (HANDLE, int, bool effective = true);
> 
> Can you please drop the default values for the effective flag here
> and add the value explicitely where necessary?  AFAICS, that only
> affects two calls in spawn.cc which should rather get an explicit
> "true".

Confirmed that those were the only two other clients, and done.  I ran out
of time for now, so it will be later today before I can polish and commit
the remaining patches (hopefully by then cgf chimes in on the
link/mkdir/rename enhancements).  I also plan on mentioning the fixed
semantics of access() as part of documenting the new euidaccess()
interface in new-features.sgml.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkq8yWIACgkQ84KuGfSFAYC0PQCbB9D8fRZli1z/JLzY2VWrwLCs
Ag0AnjSmaEXxVmAFeNElArLYXUw97U5m
=GKVl
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]