This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Honor DESTDIR in w32api and mingw


Hi Chuck,

* Charles Wilson wrote on Fri, Oct 23, 2009 at 12:36:39AM CEST:
> --- mingw/Makefile.in	27 Jul 2009 20:27:09 -0000	1.89
> +++ mingw/Makefile.in	22 Oct 2009 20:43:27 -0000

> @@ -204,6 +207,7 @@ FLAGS_TO_PASS:=\
>  	RANLIB="$(RANLIB)" \
>  	LD="$(LD)" \
>  	DLLTOOL="$(DLLTOOL)" \
> +	DESTDIR="$(DESTDIR)" \
>  	exec_prefix="$(exec_prefix)" \
>  	bindir="$(bindir)" \
>  	libdir="$(libdir)" \

> +check-DESTDIR-compatibility:
> +	 @test -z "$(DESTDIR)" || { status=0; \
> +	   for path in $(need-DESTDIR-compatibility); do \
> +	     $(MAKE) --no-print-directory $$path  DESTDIR="$(DESTDIR)" || status=$$?; \

As long as none of the subordinate makefiles initialize DESTDIR (which
they shouldn't), you don't need to ever actually need to set DESTDIR
anywhere.  But it shouldn't hurt either.

> +$(need-DESTDIR-compatibility):
> +	 @case "$($@)" in *:*) \

Wouldn't ?:* suffice?  Not that I'd like anyone to use a path with a
colon stuck in the middle of it on unix, but it certainly wouldn't be a
Win32 path.

> +	   echo DESTDIR is not supported when $@ contains Win32 path \`$($@)\'\; \

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]