This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: patch: sleep/nanosleep bug
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Wed, 18 Nov 2009 15:47:09 -0500
- Subject: Re: patch: sleep/nanosleep bug
- References: <4B045581.4040301@byu.net>
- Reply-to: cygwin-patches at cygwin dot com
On Wed, Nov 18, 2009 at 01:13:53PM -0700, Eric Blake wrote:
>2009-11-18 Eric Blake <ebb9@byu.net>
>
> * signal.cc (nanosleep): Support 'infinite' sleep times.
> (sleep): Avoid uninitialized memory.
Sorry but, while I agree with the basic idea, this seems like
unnecessary use of recursion. It seems like you could accomplish the
same thing by just putting the cancelable_wait in a for loop. I think
adding recursion here obfuscates the function unnecesarily.
cgf