This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Setting TZ may break time() in non-Cygwin programs
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Tue, 17 Apr 2012 10:19:47 -0400
- Subject: Re: [PATCH] Setting TZ may break time() in non-Cygwin programs
- References: <4F4FD8C6.5000807@t-online.de> <20120302091317.GD14404@calimero.vinschen.de> <4F513D11.2080203@t-online.de> <20120304115232.GC18852@calimero.vinschen.de> <4F53B791.2090709@t-online.de> <20120304204938.GL18852@calimero.vinschen.de> <4F85D2F4.8090204@t-online.de> <20120417070615.GA22155@calimero.vinschen.de>
- Reply-to: cygwin-patches at cygwin dot com
On Tue, Apr 17, 2012 at 09:06:15AM +0200, Corinna Vinschen wrote:
>On Apr 11 20:52, Christian Franke wrote:
>> Yes. Patch is attached.
>>
>> Christian
>>
>
>Thanks for the patch. I'm just wondering if we shouldn't generalize
>this right from the start by keeping an array of variables to skip
>when starting native apps and a function to handle this, along the
>lines of the getwinenv function and the conv_envvars array.
>It might only contain TZ now, but there's always a chance we suddenly
>stumble over a similar problem, isn't it?
I really hate having Cygwin be "smart" like this. It seems like it's
asking for a follow-on "How do I set TZ for my Windoze program???"
email, followed by a "We need a CYGWIN environment variable option!"
What's the problem with just unsetting TZ again? Yes, I know you
have to remember to do it but does this affect enough programs that
we need to add even more head standing code in Cygwin to accommodate
it.
cgf