This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 64bit] Export <io.h> symbols with underscore


On Thu, 21 Feb 2013 14:42:36 -0500, Christopher Faylor wrote:
> I wasn't fulling grokking the fact that Cygwin explicitly defined the
> get_osfhandle without an underscore in io.h.  Sigh.  That's probably my
> fault too.
> 
> But we definitely shouldn't be going back to adding "_" decorations.  I
> have deleted a few of these and no one has complained.  I know that
> isn't a scientific sampling but it's hard to believe that someone has
> written code which actually goes out of its way to prepend an underscore
> in front of a standard UNIX function name, especially since we do not,
> AFAIK, define these functions in any header file.
> 
> So, I guess I don't understand why we need to add an underscore now
> when we have gotten by with the incorrect declaration for get_osfhandle
> all of these years.

Because even if it caused a warning in C, the link still succeeded with
the underscored symbol.


Yaakov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]