Re: [PATCH] mkglobals: Fix EOL detection

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Aug 17 11:02, Orgad Shaneh wrote:
> On Mon, Aug 17, 2015 at 10:59 AM, Corinna Vinschen
> <corinna-cygwin@cygwin.com> wrote:
> > On Aug 17 10:41, Orgad Shaneh wrote:
> >> When globals.cc has CRLF line endings, winsup.h is not removed, and
> >> compilation fails for duplicate definitions.
> >
> > Why on earth should globals.h get CRLF line endings?  It's stored
> > with LF line endings in git.  There's no reason to convert the file.
> 
> globals.h is generated, I guess you refer to globals.cc.
> 
> Well, git has a setting named core.autocrlf which converts
> line-endings to CRLF on Windows.
> 
> This is very commonly used with msysGit and Git for Windows.
> 
> If the cygwin repository is cloned with autocrlf set, then all the
> source files will have CRLF line endings, including globals.cc...

You should set core.autocrlf to no in Cygwin's local git config.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpk5iKy1SEQx.pgp
Description: PGP signature