Re: [PATCH] Cygwin: define byteswap.h inlines as macros

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Mar 15 04:14, Yaakov Selkowitz wrote:
> On 2016-03-15 04:03, Corinna Vinschen wrote:
> >On Mar 14 22:13, Yaakov Selkowitz wrote:
> >>The bswap_* "functions" are macros in glibc, so they may be tested for
> >>by the preprocessor (e.g. #ifdef bswap_16).
> >ACK.
> >
> >While we're at it, what about converting the types to implicit types
> >(__uint16_t, __uint32_t, __uint64_t).
> 
> glibc uses short/int/long long for these, so I think we should leave them.

bits/byteswap.h uses __uint64_t, but you're right for the smaller types.

> >Also, do we want to convert the inline code to use the x86 bswap instructions?
> 
> Possibly, but SHTDI.

Yes.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature