This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/11] Remove dead code from fhandler_console.


On Mar 19 13:45, Peter Foley wrote:
> This if is unconditionally false, so remove it.
> 
> winsup/cygwin/fhandler_console.cc: In member function 'bool dev_console::fillin(HANDLE)':
> winsup/cygwin/fhandler_console.cc:740:22: error: self-comparison always evaluates to false [-Werror=tautological-compare]
>        if (b.dwSize.Y != b.dwSize.Y || b.dwSize.X != b.dwSize.X)
>            ~~~~~~~~~~~^~~~~~~~~~~~~
> winsup/cygwin/fhandler_console.cc:740:50: error: self-comparison always evaluates to false [-Werror=tautological-compare]
>        if (b.dwSize.Y != b.dwSize.Y || b.dwSize.X != b.dwSize.X)
>                                        ~~~~~~~~~~~^~~~~~~~~~~~~
> 
> winsup/cygwin/ChangeLog
> * fhandle_console.cc (fillin): remove dead code

Applied.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]