This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
[PATCH v2] strace: Fix "over-optimization" flaw in strace.
- From: Daniel Santos <daniel dot santos at pobox dot com>
- To: cygwin-patches at cygwin dot com
- Cc: Daniel Santos <daniel dot santos at pobox dot com>
- Date: Wed, 19 Apr 2017 11:06:02 -0500
- Subject: [PATCH v2] strace: Fix "over-optimization" flaw in strace.
- Authentication-results: sourceware.org; auth=none
- References: <20170418100400.GA29220@calimero.vinschen.de>
Recent versions of gcc are optimizing away the TLS buffer allocated in
main, so we need to tell gcc that it's really used. RtlSecureZeroMemory
accomplishes this while also inlining the memset.
Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
---
winsup/utils/strace.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/utils/strace.cc b/winsup/utils/strace.cc
index beab67b90..ae62cdc5f 100644
--- a/winsup/utils/strace.cc
+++ b/winsup/utils/strace.cc
@@ -1191,7 +1191,7 @@ main (int argc, char **argv)
registry setting to 0x100000 (TOP_DOWN). */
char buf[CYGTLS_PADSIZE];
- memset (buf, 0, sizeof (buf));
+ RtlSecureZeroMemory (buf, sizeof (buf));
exit (main2 (argc, argv));
}
--
2.11.0