This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cygwin: fork: remember child as late as possible


On Apr 12 15:31, Michael Haubenwallner wrote:
> Otherwise, when the child does fail to reload dlls and terminates, we
> produce a SIGCHILD signal, even if we did not succeed in starting up the
> child process at all.  Also, we would need to reap that child somewhere.

I'm not that happy with the patch.  The patch is doing two things, one
is to remember child as late as possible, the other is to change the
child startup in case the parent loaded dlls.

Either write a more descriptive commit message or split this into two
patches.  I'd prefer two patches.  It may help debugging.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]