Re: [PATCH] Cygwin: use win pid+threadid for forkables dirname

[Michael Haubenwallner <michael dot haubenwallner at ssi-schaefer dot com>]

On 4/13/19 9:36 AM, Achim Gratz wrote:
> Corinna Vinschen writes:
>> On Apr 12 15:32, Michael Haubenwallner wrote:
>>> Rather than newest last write time of all dlls loaded, use the forking
>>> process' windows pid and windows thread id as directory name to create
>>> the forkable hardlinks into.  While this may create hardlinks more
>>> often, it does avoid conflicts between dlls not having the newest last
>>> write time.
>>> ---
>>>  winsup/cygwin/forkable.cc | 26 +++++++-------------------
>>>  1 file changed, 7 insertions(+), 19 deletions(-)
>>
>> Pushed.
> 
> Hmm. Is it safe to use such easily predictable names?

Not sure about potential threats here, as each hardlink is (re)created
right before the child process is created.

/haubi/