This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Cygwin: make path_conv::isdevice() return false on socket files
- From: Ken Brown <kbrown at cornell dot edu>
- To: "cygwin-patches at cygwin dot com" <cygwin-patches at cygwin dot com>
- Date: Sat, 20 Jul 2019 22:53:09 +0000
- Subject: Re: [PATCH] Cygwin: make path_conv::isdevice() return false on socket files
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=cornell.edu;dmarc=pass action=none header.from=cornell.edu;dkim=pass header.d=cornell.edu;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKwBOfh6XEhhOT9JsDvDxxFV11QsmNaTu1vZ+dIeRiU=; b=glHAgbSw56NwDxR9xUWkrgKIzn/AJnEe0CoTT9MXdwAKgoMnpmaWpKbY4/KGR7sDAfvvjrIqnKvpqzOr0INp/X+c00fE9pnoDCYck5tqJtXTzDgiQoSv/38NNJCdLw+w7Zv/z4/pyCj0ja0frn0+iCLrpwoNhVWs8MlR4sUALHV+ywIn5LuiA2AHfTDELXC1RvDB6rZzFzfjuhamrjWNHZD3gsMHWp9BB34S9T+O4tHD/Xigs+aXuhJJ3R//8NiUorqNc90f7cRFzFwmp+SKhJU5aQYtq4j5mbNTk0nA11VZljjY7lf/cbnnWBYqKpgoGgBwJNHHLNFGOljhI3+MUQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KmhDuElhPn9MesyrJB423RQlBg15yqogtw5b7fHezJ1eYIU966pgUXKvYXhkD0J8GmIEQis9RpwguTuTsuGWd8it9ZOwS+sBCPlIV7+9bjloHCRUX79wBPC7lX9w14H6QVbXBNNa6IUZZrrAdXRkVgsn6sHrb1grU9vGGlZwVS7BhF9Be+sW+xC/aTePnNXJTokQm+R3ed/AfxexzZ05AnZmnC+aN31KKPG0C8CmS8PYEQSYcNEVjBSsbsURV9eluYQ7ikbVvrlrKx6cx2BXKE9JEO/FscaEWLqW4fFvjL0/NE5TbQVUoYjRAVuRmQ/SJhy+rPhXDTdlnmlH/2DhDA==
- References: <20190718200026.1377-1-kbrown@cornell.edu> <20190719082845.GO3772@calimero.vinschen.de>
On 7/19/2019 4:28 AM, Corinna Vinschen wrote:
> I see what you're doing here, but it's totally non-obvious from the
> commit message why this fixes the problem and doesn't introduce weird
> side-effects.
Thanks. I was pretty careless with this patch. There's a new patch series on
the way that (I hope) does it right.
> An editorial note: While looking into your patch it occured to me that
> it would be about time to go over all the is***device() methods and
> clean up the mess. E.g., is_fs_device() is used by is_lnk_special()
> only, is_auto_device() doesn't have much meaning,
I've removed is_fs_device() and is_auto_device()
> some funcs have
> underscores, some don't.
The convention seems to be that is<something> uses underscores if and only if
"something" is a single word. The only exception I saw is isctty_capable. I
didn't bother changing this, but I could if you want me to.
Ken