This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH 4/4] Cygwin: pty: Limit API hook to the program linked with the APIs.
On Wed, 4 Sep 2019 12:03:51 +0200
Corinna Vinschen wrote:
> I'll push the other 3 patches from this series. For this patch,
> I wonder why you create set_ishybrid_and_switch_to_pcon while
> at the same time define a macro CHK_CONSOLE_ACCESS with identical
> Suggestion: Only define set_ishybrid_and_switch_to_pcon() as
> inline function (probably in winsup.h) and use only this througout.
This function uses static variable isHybrid (sorry camelback again)
and static function set_switch_to_pcon() defined in fhandler_tty.cc.
To make it inline, a lot of changes will be necessary. How about
Takashi Yano <email@example.com>