This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cygwin: console: Revive Win7 compatibility.


On Wed, 18 Sep 2019 18:21:49 +0200
Achim Gratz wrote:
> Takashi Yano writes:
> > - The commit fca4cda7a420d7b15ac217d008527e029d05758e broke Win7
> >   compatibility. This patch fixes the issue.
> > ---
> >  winsup/cygwin/fhandler_console.cc | 10 +++++-----
> >  winsup/cygwin/select.cc           |  2 +-
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> It seems like an attractor for future bugs to define the same constant
> in two different places.  Would there be a header that could provide the
> definition instead?

I agree with you. I will post revised one as v2.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]