This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/1] Cygwin: console: Revive Win7 compatibility.


On Wed, 18 Sep 2019 17:31:30 -0400
Yaakov Selkowitz wrote:
> Would it make sense to define this using wincap so it is 2048 for
> Win7/2K8 and 3276 for newer versions?

Thanks for advice. Of cource it is possible, however, I don't think
it is necessary. IMHO, the buffer size of 2048 is more than enough
for console keyboard input. Even if the number of records exceeds
2048, call of process_input_message() will be divided into several
transactions without loss of data. Previously, process_input_message()
was called byte by byte, so the current implementation is much better
than that even with the buffer whose depth is 2048.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]